Repository navigation
fallback: return available bytes on short feed-based reads - #752
Open
zhechen-cs wants to merge 1 commit into
Open
zhechen-cs wants to merge 1 commit into
zhechen-cs wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a feed-based
Unpacker,read_bytes(5)raisesOutOfDatain the pure-Python fallback when onlyb"ab"is buffered. The C extension returnsb"ab", and both implementations already return short reads for file-backed input.Honor
raise_outofdata=Falsein the feed path so raw reads consume and return the available bytes. Normal unpacking still rolls back and raisesOutOfDatafor incomplete objects. The regression covers empty and short buffers, reads after a decoded object, stream offsets, and feeding the next object afterward.Validation on macOS arm64, CPython 3.12:
git diff --check, pass.The existing
thread_unsafemarker warning also occurs on the base. Other platforms and PyPy have not been tested locally.